Conversation
|
@codex review Review exact head Reasoning: the target Ubuntu 22.04 engine import can bind an incompatible C++ runtime when PyArrow loads before the owned SQLite binding. The correction fixes that order and adds a real-entry fresh-process guard. The soak test now observes the actual runner boundary. Windows and native Ubuntu focused tests and read-only Ruff checks passed on this exact commit. Hardware, packaging, and long-soak evidence remain open. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
This head keeps the Ubuntu 22.04 import-boundary correction unchanged. The last commit only regenerates the two derived documents. Local evidence for this exact head:
The earlier Codex verdict covered the preceding product commit. This request asks for a new verdict because the derived-document commit changed the head. @codex review this pull request at head |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33cf4183ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try: | ||
| instance._run_owned(evidence, soak.profile("short")) | ||
| except runner._RunnerActivationDisabled as exc: | ||
| blocked_by = exc | ||
| except runner._RunnerFoundationError as exc: | ||
| refused_by = exc |
There was a problem hiding this comment.
In the default Ubuntu remaining job, this file runs inside the Git-free exported candidate (tools/candidate_evidence.py:287-329; selected by tools/ci_candidate_runner.py:183-195). Before reaching write_manifest, _run_owned executes git rev-parse HEAD with check=True (scripts/soak_mock_stack_runner.py:4161-4169), which returns 128 outside a repository and raises CalledProcessError; the new handler catches only the two runner exceptions. Consequently this test makes the Ubuntu candidate partition fail rather than proving the manifest boundary. Route it through the exact-checkout registry or deterministically replace the Git-dependent prerequisites.
AGENTS.md reference: AGENTS.md:L380-L386
Useful? React with 👍 / 👎.
1 participant
Why this change exists
On the target Ubuntu 22.04 environment, importing PyArrow before the owned SQLite binding can select an incompatible C++ runtime. The engine can then fail during import before it starts acquisition.
This draft loads the owned SQLite binding first. It adds a fresh-process guard that imports the real
cryodaq.engineentry and fails if PyArrow or LanceDB is requested first. It also makes the soak-profile reachability test observe the real runner boundary.Evidence at exact commit
ce394d5364b7c399957bc2a4fb459bd3dd432b19Scope boundary
This change proves the startup import order and the runner test boundary. It does not prove hardware operation, packaging, or a long soak. Those gates stay open.
The pull request stays draft until GitHub Codex returns a clean verdict on the exact head. Full hosted checks follow that review.