Open
Conversation
Contributor
Author
|
Ok I tested it with the plugin in-game and it works great. Since the tests are passing, I think it's ready for review 😃 |
Contributor
Author
|
This being said I was reading other part of the code and noticed there's already a |
Contributor
Author
|
Sorry for the confusion, we also had a SDK update landing in the meantime which required changes on our side. |
Contributor
Author
|
Ok, so the reasoning behind this PR is:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR keeps
spawned thread handle inStreamingSoundHandleto join it onDropWhile it's probably unnecessary in most contexts, I depend on kira in audioware which runs in a video game plugin context.
In this particular context, the game can reclaim plugin's resource anytime (e.g. when player kill game in Windows taskbar), which, at times, causes race condition leading to CTD like this:

This PR also bumps
cpalto latest0.17.3as it's the continuity of the fix made there in PR 1098 for the very same reason, and available since0.17.2.