Skip to content

ai-summary: treat killed processes and pytest collection errors as crashes#127

Merged
vmilosevic merged 1 commit into
mainfrom
ppetrovic/ai-job-summary-killed
Jun 1, 2026
Merged

ai-summary: treat killed processes and pytest collection errors as crashes#127
vmilosevic merged 1 commit into
mainfrom
ppetrovic/ai-job-summary-killed

Conversation

@ppetrovicTT

Copy link
Copy Markdown
Contributor

Both were silently reported as SUCCESS. Detect SIGKILL/SIGTERM/" Killed" and "ERROR collecting" so the LLM is invoked, and surface the kill line in the error sections it reads.

…ashes

Both were silently reported as SUCCESS. Detect SIGKILL/SIGTERM/"<PID>
Killed" and "ERROR collecting" so the LLM is invoked, and surface the
kill line in the error sections it reads.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 29, 2026 13:33
@ppetrovicTT ppetrovicTT requested a review from a team as a code owner May 29, 2026 13:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Treats SIGKILL/SIGTERM-killed processes and pytest collection errors as crashes so the AI summary path runs (instead of silently reporting SUCCESS), and ensures the killer line is surfaced into the LLM's error sections.

Changes:

  • Add SIGKILL, SIGTERM, and \b\d+\s+Killed\b (bash reaper format) to HIGH_PRIORITY_PATTERNS so the kill line is extracted into error sections.
  • Extend has_crash detection in extract_log to fire on ERROR collecting (pytest collection failures) and on the same kill signals, anchored to avoid matching the English word "killed".
  • Add tests covering the new positive matches and anti–false-positive cases, plus a test that the kill line reaches error_sections.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/actions/ai_summary/tool/ai_job_summary/extract.py Adds kill-signal patterns to HIGH_PRIORITY_PATTERNS and extends has_crash regex for pytest collection errors and signal-killed processes.
.github/actions/ai_summary/tool/ai_job_summary/tests/test_extraction.py Renames/updates the has_crash test class and adds positive/negative tests for collection errors and kill detection, plus a section-extraction test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vmilosevic vmilosevic merged commit be74d50 into main Jun 1, 2026
5 checks passed
@vmilosevic vmilosevic deleted the ppetrovic/ai-job-summary-killed branch June 1, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants