ai-summary: treat killed processes and pytest collection errors as crashes#127
Merged
Conversation
…ashes Both were silently reported as SUCCESS. Detect SIGKILL/SIGTERM/"<PID> Killed" and "ERROR collecting" so the LLM is invoked, and surface the kill line in the error sections it reads. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Treats SIGKILL/SIGTERM-killed processes and pytest collection errors as crashes so the AI summary path runs (instead of silently reporting SUCCESS), and ensures the killer line is surfaced into the LLM's error sections.
Changes:
- Add
SIGKILL,SIGTERM, and\b\d+\s+Killed\b(bash reaper format) toHIGH_PRIORITY_PATTERNSso the kill line is extracted into error sections. - Extend
has_crashdetection inextract_logto fire onERROR collecting(pytest collection failures) and on the same kill signals, anchored to avoid matching the English word "killed". - Add tests covering the new positive matches and anti–false-positive cases, plus a test that the kill line reaches
error_sections.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/actions/ai_summary/tool/ai_job_summary/extract.py |
Adds kill-signal patterns to HIGH_PRIORITY_PATTERNS and extends has_crash regex for pytest collection errors and signal-killed processes. |
.github/actions/ai_summary/tool/ai_job_summary/tests/test_extraction.py |
Renames/updates the has_crash test class and adds positive/negative tests for collection errors and kill detection, plus a section-extraction test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vmilosevic
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both were silently reported as SUCCESS. Detect SIGKILL/SIGTERM/" Killed" and "ERROR collecting" so the LLM is invoked, and surface the kill line in the error sections it reads.