Add processing for acceptance criteria for ShieldBenchmarkDataMapper#115
Draft
mjeremicTT wants to merge 1 commit into
Draft
Add processing for acceptance criteria for ShieldBenchmarkDataMapper#115mjeremicTT wants to merge 1 commit into
mjeremicTT wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for processing acceptance_summary data in Shield benchmark reports. The implementation extracts acceptance_criteria as measurements and merges all acceptance_summary fields with model_spec_data into config_params, with model_spec_data keys taking precedence when conflicts occur. A new _normalize_measurement_value method converts string boolean values ("true"/"false") to floats (1.0/0.0) for proper measurement storage. Tests verify correct handling of acceptance summary data, metadata merging, and precedence rules. The changes enable tracking of acceptance criteria metrics alongside existing benchmark and evaluation data.