Skip to content

fix(types): Resolve 'tfx.' prefixed KFP v2/Vertex AI artifact types to native Python classes #7869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vkarampudi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(types): Resolve 'tfx.' prefixed KFP v2/Vertex AI artifact types to native Python classes #7869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tfx/types/artifact_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,11 @@ def get_artifact_type_class(
# We need to compare `.name` and `.properties` (and not the entire proto
# directly), because the proto `.id` field will be populated when the type
# is read from MLMD.
if (artifact_type.name == candidate_type.name and
artifact_type_name = artifact_type.name
if artifact_type_name.startswith('tfx.'):
artifact_type_name = artifact_type_name[4:]

if (artifact_type_name == candidate_type.name and
artifact_type.properties == candidate_type.properties):
return cls

Expand Down
10 changes: 10 additions & 0 deletions tfx/types/artifact_utils_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,16 @@ def testArtifactTypeRoundTrip(self):
self.assertIs(_MyArtifact,
artifact_utils.get_artifact_type_class(mlmd_artifact_type))

# Test that artifact types prefixed with 'tfx.' (as produced by KFP v2)
# are correctly resolved to their native Python classes.
mlmd_artifact_type_prefixed = metadata_store_pb2.ArtifactType()
mlmd_artifact_type_prefixed.name = 'tfx.Examples'
mlmd_artifact_type_prefixed.properties['span'] = metadata_store_pb2.INT
mlmd_artifact_type_prefixed.properties['version'] = metadata_store_pb2.INT
mlmd_artifact_type_prefixed.properties['split_names'] = metadata_store_pb2.STRING
self.assertIs(standard_artifacts.Examples,
artifact_utils.get_artifact_type_class(mlmd_artifact_type_prefixed))

def testValueArtifactTypeRoundTrip(self):
mlmd_artifact_type = standard_artifacts.String.annotate_as( # pylint: disable=protected-access
system_artifacts.Dataset)._get_artifact_type()
Expand Down
Loading