Open
Conversation
…r Python 3.12 This commit updates the TFDV build environment for Python 3.12 compatibility by ripping out ZetaSQL-dependent code and updating Python package constraints. Specific changes include: * Strip ZetaSQL: Removed `zetasql` and `six` from `WORKSPACE`. Removed the `custom_validation` cc_library, its pybind11 hook (`CustomValidateStatistics`), and related test targets, as ZetaSQL compilation fails on modern toolchains. * Modernize PyArrow & TF: Updated `setup.py` to allow `pyarrow>=14,<22` for Python >= 3.11 to avoid building legacy Arrow 10 source code. Relaxed the `tensorflow` constraint to `>=2.16,<2.18` and adjusted `tfx-bsl` / `tensorflow-metadata` base versions. * Fix Test Dependencies: Added `scikit-learn==1.5.1` and `scipy==1.17.0` to `install_requires` so the mutual information generators and tests can execute properly. * Cleanup Build Macros: Removed legacy Python 2 pybind11 initialization symbols (`init%s`) from `build_macros.bzl`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the porting of TFX to 3.12.4, this branch relaxes some of the version dependencies. Currently, it's more for discussion about the approach etc., as opposed to merging into master. For example, porting ZetaSQL to GoogleSQL is something we should do. It's not done in this particular branch, because this was more of a dry run to see what breaks.