Port tensor4all-aci elementwise API and benchmarks#512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tensor4all-acias the Rust counterpart ofAlternatingCrossInterpolation.jlelementwise ACI for tensor trains.elementwise,elementwise_batched,ElementwiseBatch,AciOptions,AciResult, typed errors, README examples, and doctested usage.tensor4all-simplett,tensor4all-tcicore, andtensor4all-tensorbackend, including deterministic tests against dense oracles.convergencecriterionshape and rejectmin_iters = 0as an invalid option.Performance Work Included
Matrix<-> tenferroTypedTensorconversion overhead with owned matrix and batched-GEMM paths.REPOSITORY_RULES.md: validate ranges once, then iterate over column-major slices in hot paths.Benchmark Snapshot
L=16 fixed-sweep local-step medians, Rust built with
tenferro-system-blasagainst Homebrew OpenBLAS:Saved details are in
benchmarks/results/2026-05-22-aci-local-step-l16-openblas.mdanddocs/plans/2026-05-22-aci-rust-api-handoff.md.Validation
git diff --checkcargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --release -p tensor4all-tensorbackend --libcargo test --release -p tensor4all-tcicorecargo test --release -p tensor4all-acicargo test --doc --release -p tensor4all-tensorbackendcargo test --doc --release -p tensor4all-acicargo test --release -p tensor4all-aci --no-default-features --features tenferro-system-blaswithRUSTFLAGS,RUSTDOCFLAGS, andDYLD_LIBRARY_PATHpointed at Homebrew OpenBLASNotes
AlternatingCrossInterpolation.jlcurrently listsMarc Ritter and contributorsin its Project.toml/LICENSE, while the paper citation is Marc Ritter.