Additional speedup of Tokenizer#20
Closed
nene wants to merge 2 commits into
Closed
Conversation
Previously the tokenizer looped over all lexemes, picking the longest one that matched. But that's too much effort. We can order the lexemes so that we'll just need to look for the first one that matches. Additionally I measured a bunch of JavaScript files to see which lexemes appear most often. The order was like this: - :SINGLE_CHAR - :S - :RAW_IDENT - :STRING - :COMMENT - :LITERALS - :NUMBER - :REGEXP As the :SINGLE_CHAR matched any character I split it up to two lexemes: one at the beginning that matches single chars that are never part of a longer lexeme, and one at the end that matches the remaining. Also I needed to tweak the :S lexeme to only match non-empty whitespace. This all together gave about 2 x speedup.
Contributor
Author
|
Closing this in favor of #24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did some further tuning of Tokenizer. Made it about 2 x faster, but had to change the code around considerably more - mostly reordering things. See the commit message for details.
Also eliminated few drops of trailing whitespace.