fix: respect PCCS_URL environment variable and fix config file format#6
Open
pkrishnath wants to merge 1 commit into
Open
fix: respect PCCS_URL environment variable and fix config file format#6pkrishnath wants to merge 1 commit into
pkrishnath wants to merge 1 commit into
Conversation
The entry.sh script had two issues: 1. Hardcoded PCCS_URL to Azure's global cache, preventing env var overrides 2. Used echo with \n which doesn't expand to newline in /bin/sh Changes: - Use bash parameter expansion to allow PCCS_URL override while keeping default - Use printf instead of echo to properly write newlines to config file This ensures /etc/sgx_default_qcnl.conf has proper format: PCCS_URL=<url> USE_SECURE_CERT=FALSE Enables bare-metal SGX deployments to use local PCCS services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
printfinstead ofechoto properly write newlines to/etc/sgx_default_qcnl.confThe entry.sh script had two issues:
echowith\nwhich doesn't expand to newline in/bin/shThis ensures
/etc/sgx_default_qcnl.confhas proper format:This enables bare-metal SGX deployments to use local PCCS services required for attestation in non-Azure environments.
Test plan
/etc/sgx_default_qcnl.confcontains properly formatted config with two lines🤖 Generated with Claude Code