fix: scope ZoneInbox refund calls#539
Open
mattsse wants to merge 1 commit into
Open
Conversation
mattsse
force-pushed
the
mattsse/fix-zone-inbox-refund-eth-call
branch
from
d9cc2a6 to
6af7d04
Compare
mattsse
force-pushed
the
mattsse/fix-zone-inbox-refund-eth-call
branch
from
6af7d04 to
5b2b8c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rejects private RPC
eth_callrequests that try to readZoneInbox.refunds(token, owner)for an owner other than the authenticated caller.Root Cause
Private RPC simulation enforced the request
fromaddress but did not inspect sensitive ZoneInbox view calldata, so callers could target the inbox predeploy and read arbitrary refund owners.Impact
Non-owner refund reads now fail before execution with the existing account-mismatch error, while own-owner reads and sequencer reads retain normal behavior.