perf: use eth_sendRawTransactionSync in Tempo verify#115
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15df587f0a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| json={ | ||
| "jsonrpc": "2.0", | ||
| "method": "eth_sendRawTransaction", | ||
| "method": "eth_sendRawTransactionSync", |
There was a problem hiding this comment.
This hard-codes eth_sendRawTransactionSync, which is not part of the standard Ethereum JSON-RPC surface, so ChargeIntent.verify() now fails on RPC providers that only expose eth_sendRawTransaction (typically with -32601 Method not found). Because ChargeIntent still accepts custom rpc_url values and the previous implementation worked with standard nodes via send+poll, this is a compatibility regression for existing deployments unless a fallback path is kept.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
not relevant for tempo
1 participant
tempoxyz/mpp-rs#199