Skip to content

fix: fix PNG chunk header bounds check in logo decoder #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dollyerls wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix: fix PNG chunk header bounds check in logo decoder #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/sync-logos.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ function decodePngPixels(buf: ArrayBuffer) {
(bytes[20] << 24) | (bytes[21] << 16) | (bytes[22] << 8) | bytes[23];
const idatChunks: Buffer[] = [];
let offset = 8;
while (offset < bytes.length - 4) {
// A chunk header is 8 bytes (4-byte length + 4-byte type), so we need at
// least 8 bytes remaining to read one safely.
while (offset <= bytes.length - 8) {
const len =
(bytes[offset] << 24) |
(bytes[offset + 1] << 16) |
Expand Down