Skip to content

chore: remove no-op protocol-version negotiation in MCP initialize #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toddfil wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −18
Open

chore: remove no-op protocol-version negotiation in MCP initialize #735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions workers/mcp-services/src/mcp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,7 @@ async function handleMessage(

switch (request.method) {
case "initialize":
return jsonRpcResult(
request.id ?? null,
initializeResult(request.params),
);
return jsonRpcResult(request.id ?? null, initializeResult());
case "notifications/initialized":
return undefined;
case "ping":
Expand Down Expand Up @@ -727,21 +724,12 @@ function isRecord(value: unknown): value is JsonObject {
return typeof value === "object" && value !== null && !Array.isArray(value);
}

function initializeResult(params: unknown) {
const requested =
typeof params === "object" && params !== null
? (params as { protocolVersion?: unknown }).protocolVersion
: undefined;
const protocolVersion =
typeof requested === "string" && requested.length > 0
? requested
: PROTOCOL_VERSION;

function initializeResult() {
// This server supports exactly one protocol version, so the response always
// advertises PROTOCOL_VERSION. Per the MCP spec this is the correct reply
// whether or not the client requested that same version.
return {
protocolVersion:
protocolVersion === PROTOCOL_VERSION
? PROTOCOL_VERSION
: PROTOCOL_VERSION,
protocolVersion: PROTOCOL_VERSION,
capabilities: {
tools: {},
},
Expand Down