fix(provider): prevent access-key retry after dispatch#680
Open
skyc1e wants to merge 1 commit into
Open
Conversation
|
@skyc1e is attempting to deploy a commit to the Tempo Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #644
Access-key send failures were all treated as safe fallback points, including failures returned after a signed raw transaction had already been handed to the transport. That could open the root wallet and submit the transaction a second time.
This keeps the existing wallet fallback for preparation and signing failures, with the original error logged, but wraps transport errors with the signed transaction hash and propagates them to the caller. The localnet regression test simulates a lost response after dispatch and verifies that only one raw transaction is sent.
Tested with:
pnpm exec tsc -b --noEmitvp lint src/core/internal/AccessKeyTransaction.ts src/core/Provider.ts src/core/Provider.localnet.test.tsvp test src/core/AccessKey.test.ts src/core/Provider.test.ts(42 tests)The new localnet case was not run locally because Docker is unavailable.