fix: select access key before computing MPP channel authorizedSigner#588
Open
TheRealRajdeep wants to merge 2 commits into
Open
fix: select access key before computing MPP channel authorizedSigner#588TheRealRajdeep wants to merge 2 commits into
TheRealRajdeep wants to merge 2 commits into
Conversation
|
@TheRealRajdeep is attempting to deploy a commit to the Tempo Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
hey, appreciate the PR. This is directionally right but will still hit edge cases:
we're considering introducing mpp_authorize to solve these |
Author
|
Ah okay. Is it possible that we work together on it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getClientcallback inProvider.tswas always using the root account address when constructingthe client for mppx. This caused the channel
authorizedSignerto be computed from the root address, meaning vouchersigning fell back to the root wallet even when a scoped access key existed.
AccessKey.select()before falling back to the root address. When a matchingaccess key is found, its address is attached as
accessKeyAddresson the client account object — which mppx alreadyreads via
getAuthorizedSignerinSession.ts.it.
Closes #518
Test plan
pnpm tsc -b --noEmitpasses (zero type errors)lib/puretest suites pass (432 tests)mpp client uses access key address as authorizedSigneradded tosrc/core/mppx.localnet.test.tspnpm dev) — will run in CI