💥 Use context-sensitive randomness for workflow views - #1558
Merged
Conversation
eamsden
force-pushed
the
eamsden/workflow-read-only-context
branch
from
September 1, 2026 21:38
341f8c9 to
5342554
Compare
eamsden
force-pushed
the
eamsden/workflow-read-only-context
branch
from
September 1, 2026 21:43
5342554 to
992e0cf
Compare
eamsden
marked this pull request as ready for review
September 1, 2026 21:43
eamsden
enabled auto-merge (squash)
September 1, 2026 21:44
chris-olszewski
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Track privately whether a workflow context view requires replay-safe randomness. All replayable execution uses workflow randomness. Queries, update validators, and patch activation callbacks use system randomness.
Breaking change
WorkflowContextViewand the containingPatchActivationInputare no longerSendorSync.Why?
Allow telemetry and tracing to safely generate identifiers with replayable randomness where appropriate, while using system randomness when history cannot be recorded and thus advancing workflow random streams would likely cause non-deterministic execution.
Checklist
Closes N/A — no linked issue.
How was this tested:
cargo +nightly fmtcargo test -p temporalio-workflow --libcargo check -p temporalio-workflow --target wasm32-unknown-unknowncargo integ-test -t wasm_workflow_tests -- --test-threads 1cargo lintcargo test-lintgit diff --checkAny docs updates needed?
CHANGELOG.mddocuments the breaking auto-trait change.