Include WorkflowType in wrapFailure error message - #2960
Merged
Quinn-With-Two-Ns merged 1 commit intoAug 27, 2026
Conversation
|
|
|
|
The "Failure processing workflow task" RuntimeException only included WorkflowId, RunId, and Attempt, forcing anyone debugging a failure to look up the workflow type separately. PollWorkflowTaskQueueResponse already carries the workflow type, so include it directly.
Quinn-With-Two-Ns
force-pushed
the
fix/wrapfailure-workflow-type
branch
from
August 27, 2026 01:44
e03dbd7 to
fac6f6e
Compare
Contributor
|
I will say, in general, that workflow task failures are generally something that happens to a specific workflow, not a specific workflow type. That being said there are cases like bad code or an NDE where workflow type would be valuable |
Quinn-With-Two-Ns
approved these changes
Aug 27, 2026
Quinn-With-Two-Ns
enabled auto-merge (squash)
August 27, 2026 01:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkflowWorker$TaskHandlerImpl.wrapFailurebuilds aRuntimeExceptionmessage ("Failure processing workflow task. WorkflowId=..., RunId=..., Attempt=...") when a workflow task fails processing, but omits the workflow type.PollWorkflowTaskQueueResponse(already available ontask.getResponse()) carries the workflow type, so this addsWorkflowType=to the message using that existing data — no new lookups or API surface required.temporal workflow describe) just to find out which workflow type failed.Test plan
WorkflowWorker/task-handler tests still pass