Conversation
liam-lowe
commented
Mar 31, 2026
| } | ||
|
|
||
| func (s *Proxy) Start() error { | ||
| s.startPProfHTTPServer() |
Contributor
Author
There was a problem hiding this comment.
I moved to top of proxy.Start() to mirror previous placement (before proxy.Start()).
There's an argument for having it in various other places (ie profiler first, health check first, etc. ) but I think this is suitable - and it mirrors previous implementation which had no concerns.
pseudomuto
approved these changes
Mar 31, 2026
| } | ||
|
|
||
| func (s *Proxy) Start() error { | ||
| s.startPProfHTTPServer() |
.gitignore
Outdated
| .claude/ | ||
|
|
||
| # Vim swap files | ||
| *.swp |
There was a problem hiding this comment.
/nit no biggie, I'm also a vim user, but I have to imagine most people have swap files disabled or have this in their own global gitignore.
If you think it's worth having here, I have no objections, but maybe we borrow from here to include all kinds of vim temp things?
hehaifengcn
approved these changes
Mar 31, 2026
Comment on lines
90
to
94
| // Waits until interrupt signal from OS arrives | ||
| select { | ||
| case <-proxyParams.Proxy.Done(): | ||
| case <-interruptCh(): | ||
| } |
Collaborator
There was a problem hiding this comment.
this can be moved to proxy.Start() as well?
liam-lowe
force-pushed
the
liam-lowe/config
branch
from
713c705 to
21ef9d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Moves initialisation of profiler into
proxy.Start()to abstract out ofmain.go.Why?
main.gois cluttered with unnecessary setup logic which should be abstracted.