Implement @nexus.default for Go and C# - #168
Open
dplyukhin wants to merge 1 commit into
Open
Conversation
tconley1428
reviewed
Aug 31, 2026
| .cloned() | ||
| .and_then(|record| proto::planned_record_field_data(&record, field_name, self.planner)) | ||
| .unwrap_or_default() | ||
| let Some(record) = self.source_spec.record(record_full_name).cloned() else { |
Collaborator
There was a problem hiding this comment.
It seems likely that given Python already implemented this, we either don't actually need the planning step (if the logic in each lang is very small), or more likely Python should have some removal of logic to share this as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
DWISOTT
Why?
It was a bug!
Checklist
Closes [Bug] [WIT] .NET and Go backends ignore @nexus.default #160
How was this tested: Updated advanced tests to check the value that's been assigned.