Skip to content

feat: generate System Nexus interceptor points - #156

Merged
tconley1428 merged 7 commits into
mainfrom
interceptor-generation
Aug 28, 2026
Merged

feat: generate System Nexus interceptor points#156
tconley1428 merged 7 commits into
mainfrom
interceptor-generation

Conversation

@tconley1428

@tconley1428 tconley1428 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add the advanced-only --system-nexus generation option
  • generate typed, operation-specific System Nexus workflow outbound interception points and their terminal dispatcher
  • enable the option for the Python workflow-service example and check in its generated output

Companion Python SDK draft PR: temporalio/sdk-python#1791.

Validation

  • cargo test --features advanced --test generate_python python_examples_generation_matches_checked_in_output -- --nocapture

@tconley1428
tconley1428 force-pushed the interceptor-generation branch 4 times, most recently from e699a98 to 0787397 Compare August 27, 2026 16:47
@tconley1428
tconley1428 marked this pull request as ready for review August 27, 2026 16:50
@tconley1428
tconley1428 requested a review from a team as a code owner August 27, 2026 16:50

@VegetarianOrc VegetarianOrc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks okay! Couple minor questions/nits. Would also love to not have to thread the system_nexus bool a ton of places but not too particular about it and not worth refactoring a ton for.

Comment thread advanced/samples/python/wit/workflow_service/_system_nexus_interceptor.py Outdated
@tconley1428
tconley1428 force-pushed the interceptor-generation branch from 445686a to aa21c86 Compare August 28, 2026 17:39
@tconley1428
tconley1428 merged commit 3c2823d into main Aug 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants