feat: generate System Nexus interceptor points - #156
Merged
Conversation
tconley1428
force-pushed
the
interceptor-generation
branch
4 times, most recently
from
August 27, 2026 16:47
e699a98 to
0787397
Compare
tconley1428
marked this pull request as ready for review
August 27, 2026 16:50
VegetarianOrc
approved these changes
Aug 27, 2026
VegetarianOrc
left a comment
Contributor
There was a problem hiding this comment.
Overall looks okay! Couple minor questions/nits. Would also love to not have to thread the system_nexus bool a ton of places but not too particular about it and not worth refactoring a ton for.
tconley1428
force-pushed
the
interceptor-generation
branch
from
August 28, 2026 17:39
445686a to
aa21c86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--system-nexusgeneration optionCompanion Python SDK draft PR: temporalio/sdk-python#1791.
Validation
cargo test --features advanced --test generate_python python_examples_generation_matches_checked_in_output -- --nocapture