This repository was archived by the owner on Oct 9, 2024. It is now read-only.
Add histogram graph query handler using go echarts library#58
Draft
annismckenzie wants to merge 3 commits intotemporalio:masterfrom
Draft
Conversation
annismckenzie
commented
Jan 24, 2023
Comment on lines
+54
to
+59
| // TODO: | ||
| // 1. Add raw data as a table (collapsed if possible) | ||
| // 2. Multiple charts / page? | ||
| // 3. Add the remaining data in a second chart: workflows started (v.Started), | ||
| // workflow executions (v.Execution), workflows closed (v.Closed) | ||
| // 4. Example used: https://github.com/go-echarts/examples/blob/master/examples/line.go |
| chart.SetGlobalOptions( | ||
| charts.WithTitleOpts(opts.Title{ | ||
| Title: fmt.Sprintf("Benchmark: %s", request.Workflow.Name), | ||
| //Subtitle: fmt.Sprintf("Steps:\n%+v", request.Steps), |
| "testing" | ||
| ) | ||
|
|
||
| // TODO: make this a runnable example? |
Author
There was a problem hiding this comment.
This isn't a test, it generates the same output as the query and saves that as a file in order to iterate on the graph settings.
Author
|
@mikhailshilkov would you want to take a look? This works but isn't fully polished. I wanted to still open the PR to get feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This adds a new
histogram_graphquery that returns the HTML with an interactive chart showing the benchmark results.This is the result if the HTML is saved to a file and opened in a browser (took a screenshot):
Why?
We read the blog post you published at https://mikhail.io/2021/03/maru-load-testing-tool-for-temporal-workflows/ but felt that manually importing the CSV into Google Sheets or something along these lines was too much manual work.
Checklist
How was this tested:
This is running in our CI pipeline. You basically start a scenario and it's started and monitored while it's running. After the scenario is done, we query the workflow and save the HTML file which can then be viewed directly in GitLab (no manual steps involved at all).
Any docs updates needed?
I added a section about the new query.