Add CONTINUE_AS_NEW_SUGGESTED_REASON and CONTINUE_AS_NEW_VERSIONING_BEHAVIOR enums. - #677
Merged
Conversation
…nue-as-new-signal
…nue-as-new-signal
…nue-as-new-signal
…nue-as-new-signal
…nue-as-new-signal
Sushisource
approved these changes
Dec 3, 2025
Sushisource
left a comment
Sushisource
left a comment
Member
There was a problem hiding this comment.
Just a few comment changes. Proactively approving.
carlydf
commented
Dec 3, 2025
Co-authored-by: Spencer Judge <spencer@temporal.io>
Co-authored-by: Spencer Judge <spencer@temporal.io>
carlydf
force-pushed
the
trampolining2
branch
from
December 9, 2025 01:03
0ea5c31 to
950a537
Compare
Shivs11
reviewed
Dec 9, 2025
Shivs11
reviewed
Dec 9, 2025
ShahabT
approved these changes
Dec 9, 2025
…d move optional-override-version into separate PR
stephanos
pushed a commit
that referenced
this pull request
Mar 10, 2026
…G_BEHAVIOR` enums. (#677) _**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> - Allow user to specify in ContinueAsNewOptions what the initial versioning behavior of the continued-as-new workflow should be. User can say AutoUpgrade if they want their workflow to upgrade on continue-as-new. - Define `CONTINUE_AS_NEW_SUGGESTED_REASON`. `suggest_continue_as_new = true, reason = TARGET_WORKER_DEPLOYMENT_VERSION_CHANGED` will be sent to the SDK with each workflow task, if the target version of the workflow is different than the deployment version that the workflow is currently on. Workflow code should listen to this and decide whether to ContinueAsNew based on the suggestion and reason(s) for the suggestion. <!-- Tell your future self why have you made these changes --> We want to offer a way for users to guarantee workflow pinning within a run, while still upgrading to the latest Current/Ramping version on the continue-as-new boundary. In Phase 2 of Trampolining (which is "proactive wakeup for sleeping workflows"), a separate workflow attribute will be added to allow workflows to receive a proactive wake-up when a new version is available. Pro-active wakeup would cause sleeping workflows to wake up and have the opportunity to check `continue_as_new_suggested` and continue-as-new if they choose. This is orthogonal to "will I upgrade when I continue-as-new," and applicable to both Pinned and AutoUpgrade workflows. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** temporalio/temporal#8784 --------- Co-authored-by: Spencer Judge <spencer@temporal.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.
CONTINUE_AS_NEW_SUGGESTED_REASON.suggest_continue_as_new = true, reason = TARGET_WORKER_DEPLOYMENT_VERSION_CHANGEDwill be sent to the SDK with each workflow task, if the target version of the workflow is different than the deployment version that the workflow is currently on. Workflow code should listen to this and decide whether to ContinueAsNew based on the suggestion and reason(s) for the suggestion.We want to offer a way for users to guarantee workflow pinning within a run, while still upgrading to the latest Current/Ramping version on the continue-as-new boundary.
In Phase 2 of Trampolining (which is "proactive wakeup for sleeping workflows"), a separate workflow attribute will be added to allow workflows to receive a proactive wake-up when a new version is available. Pro-active wakeup would cause sleeping workflows to wake up and have the opportunity to check
continue_as_new_suggestedand continue-as-new if they choose. This is orthogonal to "will I upgrade when I continue-as-new," and applicable to both Pinned and AutoUpgrade workflows.Breaking changes
Server PR
temporalio/temporal#8784