Draft
fix: fail fast on DeepL 403 and prevent silent untranslated PR creation#1567
Conversation
Copilot
AI
changed the title
fix: abort on DeepL 403 auth errors and exit non-zero on translation failures
fix: fail fast on DeepL 403 and prevent silent untranslated PR creation
Jul 30, 2026
Copilot created this pull request from a session on behalf of
sonvnn
July 30, 2026 03:29
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-translate silently produces PRs with English "translations" when the DeepL API key is invalid — every batch returns 403, the broad
except Exceptionfalls back to source text, and the workflow exits 0.Changes
urllib.error.HTTPErrorexplicitly; raiseRuntimeErrorimmediately on auth/quota errors instead of falling back to source text and burning through all remaining batches"Wrong endpoint. Please use the DeepL API Free endpoint…") and includes it in the error messagesync_localereturns{"error": ...}on abort (no file written);mainexits non-zero when any locale fails → CI step fails →Check for modified filesand PR-creation steps are skippedDEEPL_API_KEY.strip()guards against trailing whitespace/newlines in the secret valueERRORrow for failed locales instead of misleading coverage stats