Repository navigation
Add desktop scaling to fit the viewer window - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Display option, Scale desktop to window, that fits the remote desktop to the viewer as the window is resized while preserving its aspect ratio.
-ScaleToWindowenables the same behavior from the command line; the setting is saved in viewer configurations and takes precedence over remote desktop resizing.Drawing dimensions are independent of the remote framebuffer. Mouse coordinates, cursor size/hotspot, server cursor positioning, and “Resize window to session” use the appropriate dimensions. The Windows workflow also produces a portable release viewer with its runtime DLLs for desktop deployment, after the diagnostic integration test passes.
Native scaling is implemented for X11, Windows, and macOS, with a cached scaled surface invalidated by framebuffer updates.
Validation: Linux viewer builds successfully. Live RFB/Xvfb checks passed for scaling up/down, letterboxing/pillarboxing, mouse clicks, partial updates, server framebuffer resizing, disabling the setting through the Display UI, and RemoteResize precedence. Saving/reloading the configuration also passed. Windows build and integration validation will run in CI before merging and desktop deployment.