Event exposures need to watch applications#404
Open
julius-malcovsky wants to merge 2 commits into
Open
Conversation
Co-authored-by: Björn Kottner <BjoernKarma@users.noreply.github.com> Co-authored-by: Ismael Garba <iagarba@users.noreply.github.com> Co-authored-by: Stefan Siber <stefan-ctrl@users.noreply.github.com> Co-authored-by: Ron Gummich <ron96g@users.noreply.github.com>
Co-authored-by: Björn Kottner <BjoernKarma@users.noreply.github.com> Co-authored-by: Ismael Garba <iagarba@users.noreply.github.com> Co-authored-by: Stefan Siber <stefan-ctrl@users.noreply.github.com> Co-authored-by: Ron Gummich <ron96g@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses cases where newly created EventExposure resources can remain stuck waiting for the provider Application to become ready, because the EventExposure controller previously did not watch Application updates.
Changes:
- Added an
Applicationwatch to theEventExposurecontroller so provider readiness/status changes trigger reconciles. - Implemented
MapApplicationToEventExposureto enqueueEventExposurereconciles for exposures referencing the changedApplication. - Added a
//nolint:duplannotation to document intentional similarity between the exposure/subscription application-mapping functions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
event/internal/controller/eventexposure_controller.go |
Watches Application resources and maps application updates to affected EventExposure reconcile requests. |
event/internal/controller/eventsubscription_controller.go |
Adds a //nolint:dupl annotation to document intentional duplication with the new exposure mapping function. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can happen that a new event exposure gets stuck waiting for an application to become ready. The application actually is ready, but the exposure doesnt watch the CR.