added issue date in response#132
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the tracking content service to retrieve and include certificate timestamps (issuedOn, createdOn, and updatedOn) in the dashboard data structure. The review feedback suggests defining local interfaces (CertificateInfo and UserStatus) to avoid duplicating inline type definitions and to keep the code DRY and maintainable.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| const statusMap = new Map< | ||
| string, | ||
| { status: string; issuedOn: Date | null; createdOn: Date | null; updatedOn: Date | null } | ||
| >(); |
There was a problem hiding this comment.
To improve maintainability and avoid duplicating the certificate fields and their types, consider defining a local interface CertificateInfo and using it for the statusMap definition.
interface CertificateInfo {
status: string;
issuedOn: Date | null;
createdOn: Date | null;
updatedOn: Date | null;
}
const statusMap = new Map<string, CertificateInfo>();| const userStatusMap: Record< | ||
| string, | ||
| { | ||
| status: string; | ||
| highestAttempt: number; | ||
| issuedOn: Date | null; | ||
| createdOn: Date | null; | ||
| updatedOn: Date | null; | ||
| } | ||
| > = {}; |
There was a problem hiding this comment.
Instead of duplicating the inline type definition for userStatusMap, you can define a local interface UserStatus that extends CertificateInfo to keep the code clean and DRY.
interface UserStatus extends CertificateInfo {
highestAttempt: number;
}
const userStatusMap: Record<string, UserStatus> = {};1 participant
No description provided.