resumeData column support added#124
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new resumeData field to track content progress, updating the DTO, entity, and various database queries. The review feedback highlights a critical PostgreSQL syntax error where resumeData was added to a SELECT statement without being included in the GROUP BY clause. Additionally, the reviewer noted that resumeData is missing from an outer query's SELECT list, preventing it from being returned in the response, and suggested updating the entity's TypeScript type to number | null to correctly reflect its nullable database status.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| ct."createdOn", | ||
| ct."resumeData", |
There was a problem hiding this comment.
This query will fail at runtime in PostgreSQL. Since you added ct."resumeData" to the SELECT list of the content_status CTE but did not include it in the GROUP BY clause (lines 600-605), PostgreSQL will throw a syntax error: column "ct.resumeData" must appear in the GROUP BY clause or be used in an aggregate function. Since resumeData is not used anywhere in this method or its returned payload, it should be removed from the query.
| ct."createdOn", | |
| ct."resumeData", | |
| ct."createdOn", |
| "updatedOn", | ||
| "unitId", | ||
| "tenantId", | ||
| "resumeData", |
There was a problem hiding this comment.
| type: 'double precision', | ||
| nullable: true, | ||
| }) | ||
| resumeData: number; |
There was a problem hiding this comment.
Since the resumeData column is defined as nullable: true, its TypeScript type should reflect that it can be null. Otherwise, strict null checks (if enabled or enabled in the future) will not catch potential null pointer issues at runtime.
| resumeData: number; | |
| resumeData: number | null; |


No description provided.