Skip to content

resumeData column support added#124

Merged
rushi-tekdi merged 1 commit into
tekdi:AI-assessmentfrom
rushi-tekdi:AI-Assessment
Jun 8, 2026
Merged

resumeData column support added#124
rushi-tekdi merged 1 commit into
tekdi:AI-assessmentfrom
rushi-tekdi:AI-Assessment

Conversation

@rushi-tekdi

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: de4d9585-cd9c-4501-abf4-9159e57523f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rushi-tekdi
rushi-tekdi merged commit c18c21a into tekdi:AI-assessment Jun 8, 2026
1 check was pending
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
4.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new resumeData field to track content progress, updating the DTO, entity, and various database queries. The review feedback highlights a critical PostgreSQL syntax error where resumeData was added to a SELECT statement without being included in the GROUP BY clause. Additionally, the reviewer noted that resumeData is missing from an outer query's SELECT list, preventing it from being returned in the response, and suggested updating the entity's TypeScript type to number | null to correctly reflect its nullable database status.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines 585 to +586
ct."createdOn",
ct."resumeData",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This query will fail at runtime in PostgreSQL. Since you added ct."resumeData" to the SELECT list of the content_status CTE but did not include it in the GROUP BY clause (lines 600-605), PostgreSQL will throw a syntax error: column "ct.resumeData" must appear in the GROUP BY clause or be used in an aggregate function. Since resumeData is not used anywhere in this method or its returned payload, it should be removed from the query.

Suggested change
ct."createdOn",
ct."resumeData",
ct."createdOn",

"updatedOn",
"unitId",
"tenantId",
"resumeData",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The "resumeData" column is selected in the latest_content CTE, but it is missing from the outer query's SELECT list (lines 460-471). As a result, resumeData will not be returned in the response of searchStatusContentTracking. To fix this, please add "resumeData" to the outer query's SELECT list.

type: 'double precision',
nullable: true,
})
resumeData: number;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the resumeData column is defined as nullable: true, its TypeScript type should reflect that it can be null. Otherwise, strict null checks (if enabled or enabled in the future) will not catch potential null pointer issues at runtime.

Suggested change
resumeData: number;
resumeData: number | null;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant