-
Notifications
You must be signed in to change notification settings - Fork 1
Chore/add logs #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hemusimple
wants to merge
15
commits into
tejpratap46:chore/timber-logging
Choose a base branch
from
hemusimple:chore/add-logs
base: chore/timber-logging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chore/add logs #28
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a3a88c7
added extra logs
hemusimple 56f603a
Add Kotlin PR review workflow configuration
hemusimple 04cab66
Add Kotlin PR review workflow configuration
hemusimple 3a6ea4f
Delete kotlin-review.yml
hemusimple 7b9d97b
Update Python command to use python3 in CI workflow
hemusimple aca19ec
Change pip install command to pip3 with specific packages
hemusimple 6b998e7
Add getData function to LyricsActivity
hemusimple 49e27b6
Update getData method to return string representation
hemusimple 360576e
Add song property to LyricsActivity
hemusimple 571eb7e
Update Python installation and script path in workflow
hemusimple cb731ee
Activate virtual environment in CI workflow
hemusimple 4e1e7d0
Change shell from pwsh to powershell in workflow
hemusimple 8fd40d0
Fix output redirection in Kotlin review workflow
hemusimple 57d9a78
Change activation script and shell for CI workflow
hemusimple c5c17e8
Modify review script execution in workflow
hemusimple File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| name: Kotlin PR Review | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, reopened, synchronize] | ||
|
|
||
| jobs: | ||
| kotlin_review: | ||
| runs-on: code-review # ← matches the label you gave your runner | ||
|
|
||
| timeout-minutes: 15 | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 # full history needed for git diff | ||
|
|
||
| - name: Run Kotlin Review Agent | ||
| env: | ||
| PLATFORM: github | ||
| REVIEWER_TOKEN: ${{ secrets.REVIEWER_TOKEN }} | ||
| OLLAMA_HOST: ${{ secrets.OLLAMA_HOST }} | ||
| OLLAMA_MODEL: ${{ secrets.OLLAMA_MODEL }} | ||
| # Map GitHub context vars to the names review_ci.py expects | ||
| CI_PROJECT_DIR: ${{ github.workspace }} | ||
| CI_PROJECT_ID: ${{ github.repository }} # e.g. hemusimple/AndroidVideoMotion | ||
| CI_MERGE_REQUEST_IID: ${{ github.event.pull_request.number }} | ||
| CI_MERGE_REQUEST_TARGET_BRANCH_NAME: ${{ github.event.pull_request.base.ref }} | ||
| CI_MERGE_REQUEST_SOURCE_BRANCH_NAME: ${{ github.event.pull_request.head.ref }} | ||
| CI_MERGE_REQUEST_TITLE: ${{ github.event.pull_request.title }} | ||
| CI_COMMIT_AUTHOR: ${{ github.event.pull_request.user.login }} | ||
|
|
||
| run: | | ||
| call D:\AIML\code-reviewer\myvenv\Scripts\activate.bat | ||
| pip install -q httpx python-dotenv pydantic pydantic-settings ollama loguru tenacity | ||
| python D:\AIML\code-reviewer\review_ci.py | ||
| exit 0 | ||
| shell: cmd | ||
|
|
||
|
|
||
| - name: Upload review log | ||
| uses: actions/upload-artifact@v4 | ||
| if: always() | ||
| with: | ||
| name: review-output | ||
| path: review_output.log | ||
| retention-days: 7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency and better maintainability, use the
TAGconstant defined in the companion object instead of a hardcoded string literal. This ensures that the log tag remains uniform across the class and is easier to update if needed. Also, added a space after the comma for better readability.