Skip to content

Expand release trigger types in workflow#11

Closed
tejpratap46 wants to merge 2 commits into
mainfrom
chore/include-all-release-types
Closed

Expand release trigger types in workflow#11
tejpratap46 wants to merge 2 commits into
mainfrom
chore/include-all-release-types

Conversation

@tejpratap46

@tejpratap46 tejpratap46 commented Dec 12, 2025

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Updated the release workflow to trigger on additional release event types.
    • Confirmed that no other workflow steps or logic were changed.

✏️ Tip: You can customize this high-level summary in your review settings.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The GitHub Actions Android release workflow trigger was changed to fire on a broader set of release event types. The trigger list was modified from a single published event to include published, created, edited, prereleased, and released. No other workflow steps were changed.

Changes

Cohort / File(s) Change Summary
Workflow Release Trigger Configuration
\.github/workflows/android-release\.yml
Updated on.release.types trigger from [published] to [published, created, edited, prereleased, released] — no other workflow logic or steps modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single configuration file change; review should focus on YAML syntax and validating the intended GitHub release events.
  • Check that no downstream steps assume a narrower set of release types.

Poem

🐰 I hopped through YAML with a cheerful spin,

Triggers widened—let the release hops begin!
Published, created, edited—prerelease too,
The pipeline stretches its ears for the view. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Expand release trigger types in workflow' accurately and concisely summarizes the main change: modifying GitHub Actions workflow to include additional release event types beyond just 'published'.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/include-all-release-types

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90ccbfd and ff7b6c2.

📒 Files selected for processing (1)
  • .github/workflows/android-release.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: build
  • GitHub Check: dependency-submission
  • GitHub Check: Build app
  • GitHub Check: Build lyrics-maker

Comment thread .github/workflows/android-release.yml Outdated
Removed 'unpublished' and 'deleted' types from release triggers.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/android-release.yml (1)

3-6: Confirm intent for triggering on created/edited/prereleased (job will often skip, or may re-upload assets).

Given the job-level gate (Line 13) skips drafts and prereleases, created and prereleased will usually just create a workflow run with a skipped job; edited can cause asset re-uploads/overwrites on any metadata edit. If that’s not intended, consider narrowing types back to the minimal set (often published and/or released) or adding an explicit github.event.action allowlist in the job if.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff7b6c2 and 53b8b04.

📒 Files selected for processing (1)
  • .github/workflows/android-release.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build lyrics-maker
  • GitHub Check: dependency-submission
  • GitHub Check: Build app
  • GitHub Check: build

@tejpratap46 tejpratap46 self-assigned this Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant