Skip to content

Refine Android release workflow and APK handling#10

Merged
tejpratap46 merged 1 commit into
mainfrom
chore/fix-release-action
Dec 12, 2025
Merged

Refine Android release workflow and APK handling#10
tejpratap46 merged 1 commit into
mainfrom
chore/fix-release-action

Conversation

@tejpratap46

@tejpratap46 tejpratap46 commented Dec 12, 2025

Copy link
Copy Markdown
Owner

Updated the workflow to ensure it only runs for non-pre-release and non-draft releases. Enhanced the APK path definition and output handling for better clarity and functionality.

Summary by CodeRabbit

  • Chores
    • Updated the Android release workflow to restrict automatic releases to stable versions, excluding pre-releases and drafts.
    • Enhanced APK file discovery and streamlined the release upload process for improved reliability in Android releases.

✏️ Tip: You can customize this high-level summary in your review settings.

Updated the workflow to ensure it only runs for non-pre-release and non-draft releases. Enhanced the APK path definition and output handling for better clarity and functionality.
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

The Android release workflow is refactored to add a guard preventing execution for prerelease and draft releases, replaces the APK path discovery mechanism with a simplified find command into an APK_FILES variable, and updates the release upload action to v2 with conditional execution and overwrite support.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/android-release.yml
Added guard condition for non-prerelease/non-draft releases; refactored APK discovery using find command into APK_FILES variable with multi-line heredoc output; removed intermediate "Show built APK paths" step; updated release upload to use softprops/action-gh-release@v2 with conditional execution and overwrite_files: true

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify the guard condition syntax and its interaction with GitHub release event triggers
  • Validate the find command pattern for -debug.apk files and heredoc output formatting
  • Confirm the conditional logic for empty APK_FILES handling and warning message
  • Check the softprops/action-gh-release@v2 API compatibility with the newline-separated file input format

Poem

🐰 A workflow takes shape with careful control,
Guards at the gates, drafts don't take toll,
APKs now found with a swift little find,
Released to the masses, all sorted and aligned! ✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/fix-release-action

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 17d0be0 and 295a2dd.

📒 Files selected for processing (1)
  • .github/workflows/android-release.yml (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tejpratap46 tejpratap46 merged commit 90ccbfd into main Dec 12, 2025
4 of 7 checks passed
@tejpratap46 tejpratap46 deleted the chore/fix-release-action branch December 12, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant