replicate scripts/* w/wrapper function 'dopplerctl'#81
Open
thinkmassive wants to merge 1 commit intotee8z:masterfrom
Open
replicate scripts/* w/wrapper function 'dopplerctl'#81thinkmassive wants to merge 1 commit intotee8z:masterfrom
thinkmassive wants to merge 1 commit intotee8z:masterfrom
Conversation
TODO reconcile scripts expecting signet and binary+doppler_files using regtest Reproduces the functionality of existing scripts with slightly different syntax: aliases.sh converter.sh docker_clear.sh ping_test.sh reset.sh volumes_clear.sh Source the file, then use 'dopplerctl' to run the functions as subcommands: source dopplerctl.sh && dopplerctl 1-level completion is available for bash (not passed through to subcommands yet): source <(dopplerctl completion bash)
Owner
|
Hey just taking a look at this, the default network can be assumed to be regtest (normally people will probably use doppler just on their local cluster of nodes not connected to a wider network) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's an attempt to consolidate existing scripts to a single file, which would be a little easier to include in a release tarball (see #76). Reviewing the script will make the most sense if you start with the
dopplerctl()function near the bottom (line 198ish). If you prefer the existing setup, no worries we can bundle those individual scripts instead, and feel free to let me know any related script improvements you'd find helpful.Reproduces the functionality of existing scripts with slightly different syntax:
Source the file, then use
dopplerctlto run the functions as subcommands:1-level completion is available for bash (not passed through to subcommands yet):
I've been waiting to resolve one last TODO before opening this:
...I think it'd help to get your input on expected usage, and we can set the default network based on that.
References:
shiftbuiltin used for calling a function based on subcommand parameter