[huyplb]

From the 2026-11-01 manual walk.

Safe-mode confirm (WriteConfirmDialog, sql-write-confirm): a plain div.modal-overlay, so a screen reader wasn't told a dialog had opened. It now has role="dialog", aria-modal="true", and aria-labelledby pointing at its title, e.g. Safe mode: run UPDATE statements?

Saved Credentials (CredentialManager):

• the same dialog semantics, named Saved Credentials
• Escape closes it, like the other dialogs. It doesn't while the credential form is open on top, so Escape closes only the top layer.
• the icon-only close button (cred-close-btn) is now named Close saved credentials and has type="button"

useEscapeKey (shared/lib/useEscapeKey.ts) is the Escape listener that WorkspaceSettingsDialog and others each write by hand: a ref for the callback, registered once, skipping keys another handler already claimed. It adds an enabled flag for layered dialogs. I haven't moved the existing hand-written listeners over, to keep this PR small.

Tests:

• WriteConfirmDialog.test.tsx: role and name
• CredentialManager.test.tsx: role, name and close-button name; Escape closes; Escape with the form open doesn't

A/B: without the fix, 3 of the 4 fail. With Escape unguarded, the form-on-top test fails. With the fix, all pass.

Live check: I opened Saved Credentials in the app and confirmed the dialog role, name and button label, and that a real Escape closes it. tsc, eslint and the naming test are clean.

🤖 Generated with Claude Code

---

Note

Low Risk
UI-only accessibility and Escape handling; no auth, SQL execution, or data persistence changes.

Overview
Improves screen reader and keyboard behavior for two overlays that were plain divs before.

WriteConfirmDialog now exposes role="dialog", aria-modal="true", and aria-labelledby tied to its dynamic title (e.g. Safe mode: run UPDATE statements?) via useId.

Saved Credentials (CredentialManager) gets the same dialog semantics, names the icon close control Close saved credentials (type="button"), and closes on Escape through a new shared useEscapeKey hook. Escape is disabled while add/edit opens ConnectionModal on top so only the top layer dismisses.

Adds Vitest coverage for dialog role/name and Escape layering; test-id docs note the close button label.

^{Reviewed by Cursor Bugbot for commit 677a7ed. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit bf24fd4. Configure here.}

[cursor]

Form layer leaves Escape unhandled

Medium Severity

useEscapeKey is disabled while adding or editing so Escape can close the credential form on top, but ConnectionModal has no Escape handler. After Add or Edit Credential, Escape dismisses neither layer. Users who just used Escape to close Saved Credentials now get no response.

 

^{Reviewed by Cursor Bugbot for commit bf24fd4. Configure here.}