Repository navigation
fix(data-peek): the grid shows its rows again, Escape closes one thing, the Limit box tells the truth - #553
Merged
Merged
Conversation
…iled fetch) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ever hide the rows Main's multi-row filter (WHERE and ORDER BY rows) grew the controls above the grid while the panel kept a fixed 360 px: with two filter rows the grid showed its header and none of its rows. The height is now the body's (grid or Insight); the controls take what they need. The e2e follows the new filter: the refusal text, and one WHERE row per AND condition. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: e5f8fa5b-b9a5-4283-86af-aa75f8c04ede) |
Contributor
Test IDsAdded (1)
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 71949c68-ad5d-4024-9e5c-10deb76e94d2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
30ed394315) made the controls above the grid taller. With two filter rows the grid showed only its header. The height now belongs to the panel's body (the grid or Insight), and the controls take what they need. Dragging the handle still resizes the panel. Saved heights now mean the body's height.Tests
sql-editor-data-peek-grid.test.ts(new) passes 14/14 against this branch, using SQLite. It covers paging, WHERE, ORDER BY, refusals, foreign-key drill and stacking, Referenced by, closing, both Escape cases, a failed page fetch, and Insight. Five of these failed before the height fix, because every click on a grid row landed on the sticky header.sql-editor-peek-stackingandsql-editor-peek-row-form(Postgres) pass. They also exercise peek panels.DataPeekPanel.test.tsxchecks that the height is on the body. It fails on the old layout and passes on the new. The sql-editor and shared suites pass: 894 tests.🤖 Generated with Claude Code
Note
Medium Risk
Touches SQL Editor peek layout, keyboard handling, and paging state in
useSqlEditorStore; regressions would affect a heavily used preview UI but changes are localized with broad new e2e coverage.Overview
Data Peek no longer squeezes the grid when multiple WHERE/ORDER BY rows are open: resizable height applies to the body (
data-peek-body-{id}) that holds the grid or Insight, while filter chrome grows naturally. Saved/dragged heights are body heights, with updated defaults and min/max.Escape is scoped so one keypress closes one layer: the save-as-variable input calls
preventDefaulton Escape, and the peek shell skips closing whendefaultPrevented(including grid cell deselect).Limit input is clamped on apply via
clampDataPeekLimitand written back so the field matches the limit actually in force. After a failed page fetch,pageIndexreverts to the last good page so row numbers and the footer page label stay aligned with visible rows.Adds SQLite e2e
sql-editor-data-peek-grid.test.ts(paging, filters, FK drill, Escape, failed fetch, Insight tab), wires it intorun-all.mjs, documentsdata-peek-body-{id}, and a unit test that body—not the outer grid wrapper—owns the fixed height.Reviewed by Cursor Bugbot for commit 801e6a9. Bugbot is set up for automated code reviews on this repo. Configure here.