Skip to content

Inno Setup installer issue - Fix strings - #13

Merged
techygeekshome merged 2 commits into
techygeekshome:mainfrom
bovirus:main
Sep 29, 2026
Merged

techygeekshome merged 2 commits into
techygeekshome:mainfrom
bovirus:main

Conversation

@bovirus

@bovirus bovirus commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

@techygeekshome

There is an issue in Installer script.

The string showed at the end ("Run xxx") is already included in inno Setup base language (isl. file) and is strinmg with id "LaunchProgram" (the strings is "Run xxx" - not like now "Open xxx".

The strings "english.LaunchApp" is not necessary.

Please replicate these fixes in other program (except PDFGeek that is already OK).

Thanks.

@techygeekshome

Copy link
Copy Markdown
Owner

Thanks bovirus, agreed. One small thing: LaunchProgram needs the app name passed in, the same as PDFGeek, so {cm:LaunchProgram,{#MyAppName}} rather than {cm:LaunchProgram}, otherwise the checkbox shows %1 instead of the name. If you can add that I'll merge it.

I've made the same change in CleanGeek (#11), DriverGeek (#13), CutGeek, TranscribeGeek, SoundGeek and AuthGeek (#1 in each). AppGeek and LingoGeek already use it.

@bovirus

bovirus commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor Author

@techygeekshome

You can use {cm:LaunchProgram}.

It replace with "Execute %1" string where %1 is the program name.

Could you please enable multilanguage installer for all programs (ex. including Ultimate Settings Panel)?

Could you please make the same scheme for program file naming like

xxxx-setup.exe - for installer version
xxx-portable.zip/.exe - for portable version?

Thanks.

@techygeekshome

Copy link
Copy Markdown
Owner

@bovirus thanks for both suggestions.

Multi-language installers: yes. I'll add the Inno Setup language selector to every app that doesn't have it yet, Ultimate Settings Panel included, and it will ship with each app's next release.

File naming: I'm going to keep the current names. The installers are already consistent as NameSetup.exe, and the portable builds as Name-portable.exe. Those exact names are used by the download links on the website, the winget and Chocolatey packages, and existing releases/latest/download/... links, so renaming them would break downloads for people. Ultimate Settings Panel and the older PDFGeek/AppGeek portable files are the odd ones out, and I'll bring them in line with Name-portable where I can do it without breaking an existing link.

On LaunchProgram: Inno's default message is Launch %1, so without the argument the %1 is left unfilled in the checkbox text. That's why the other apps pass {cm:LaunchProgram,{#MyAppName}}. If you can add that here I'll merge it.

@techygeekshome
techygeekshome merged commit 9283944 into techygeekshome:main Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants