fix(provider): silence tagliatelle for max_tokens#14
Merged
Conversation
The Anthropic API and other upstream providers require snake_case field names. Restore the json:"max_tokens" tags and add per-line //nolint:tagliatelle directives so the camelCase rule doesn't push us back into a broken rename. Signed-off-by: Andre Nogueira <aanogueira@protonmail.com>
actions/setup-go@v6 already caches ~/.cache/go-build and ~/go/pkg/mod keyed on go.sum. The extra actions/cache step raced with setup-go's own save (visible as 'Unable to reserve cache with key ... another job may be creating this cache.' in the Lint job) and blew up the Windows Test job in 0s, which then cancelled the rest of the matrix. Signed-off-by: Andre Nogueira <aanogueira@protonmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json:\"max_tokens\"tags onAnthropicRequest.MaxTokensandChatRequest.MaxTokens(the previous unstaged rename tomaxTokenswould have broken the Anthropic API call fixed in 81a39fd).//nolint:tagliatelledirectives with a short reason so the camelCase rule doesn't push us back into a broken rename.Test plan
golangci-lint run ./internal/provider/...→ no issues