[REFACTOR/#372] 네비게이션 구조 수정 #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boiledeggg
approved these changes
Apr 11, 2025
| import kotlinx.serialization.SerialName | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| private const val SPLASH_PATH: String = "terning://splash" |
Member
There was a problem hiding this comment.
함수를 없애고 URL로 탐색되도록 바꾼거군요?? 딥링크의 세계란...
| .currentBackStackEntryAsState().value?.destination | ||
|
|
||
| val startDestination = Splash | ||
| fun startDestination(redirect: String?) = Splash(redirect = redirect) |
Member
There was a problem hiding this comment.
함수로 바뀐거라면 이름도 바꿀 필요가 있어보이네요!
| companion object { | ||
| private const val REDIRECT: String = "redirect" | ||
|
|
||
| @JvmStatic |
Member
There was a problem hiding this comment.
여기에 JvmStatic을 붙여준 이유가 뭔가요? FirebaseMessagingService 내부에서 호출돼서 그런건가요??
Member
Author
There was a problem hiding this comment.
사실 xml로 프로젝트를 할 때 액티비티에 인텐트를 사용할 일이 있으면 저렇게 @JvmStatic을 붙여주는 게 습관이 돼서 붙였었는데요..!
찾아보니까 굳이 넣을 필요 없을 것 같아서 빼두겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
:core:navigator모듈 생성:feature:main,:core:firebase모듈 의존성 수정terningScheme 등록MessagingService코드 작성:feature:splash모듈 만들기📸 Screenshot
📢 To Reviewers