[UI/#357] 홈페이지 로딩 인디케이터 #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 페이징 관련 코드 분리 recommendedInternLazyList - LoadState에 따른 화면 분기
leeeyubin
approved these changes
Mar 26, 2025
Member
leeeyubin
left a comment
leeeyubin
left a comment
There was a problem hiding this comment.
로직이 길어지면서 함수로 빼주는 건 좋은 것 같습니당
Comment on lines
382
to
383
| TerningLottieAnimation( | ||
| jsonFile = com.terning.core.designsystem.R.raw.paging_loading_animation, |
Member
There was a problem hiding this comment.
Suggested change
| TerningLottieAnimation( | |
| jsonFile = com.terning.core.designsystem.R.raw.paging_loading_animation, | |
| TerningLottieAnimation( | |
| jsonFile = R.raw.paging_loading_animation, |
임포트로 빼주세용
Hyobeen-Park
approved these changes
Mar 26, 2025
arinming
approved these changes
Mar 26, 2025
Contributor
arinming
left a comment
arinming
left a comment
There was a problem hiding this comment.
함수로 빼주니까 Column의 역할이 가벼워 진 것 같고 가독성도 좋아졌넹요!!! 수고하셨습니당 ㅠ ㅠ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
250325_.mp4
📢 To Reviewers