Skip to content

Detect Mints - #857

Open
michielderoos wants to merge 2 commits into
masterfrom
detect-mints
Open

michielderoos wants to merge 2 commits into
masterfrom
detect-mints

Conversation

@michielderoos

@michielderoos michielderoos commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

Describe the Pull Request

Adds mint type which we can filter by!
Note: One side effect is that this changes the metrics slightly (but I think in a desirable way) because it will keep massive spikes out of transfer metrics on mint days.
Note 2: This is not retroactive

Todo

@michielderoos
michielderoos marked this pull request as ready for review September 15, 2022 17:36
@michielderoos

Copy link
Copy Markdown
Contributor Author

@codecov

codecov Bot commented Sep 15, 2022

Copy link
Copy Markdown

Codecov Report

Merging #857 (7b59fdf) into master (6c86535) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master     #857   +/-   ##
=======================================
  Coverage   47.79%   47.79%           
=======================================
  Files         374      374           
  Lines       19428    19432    +4     
  Branches     1793     1793           
=======================================
+ Hits         9285     9287    +2     
- Misses      10128    10130    +2     
  Partials       15       15           
Flag Coverage Δ
javascript 4.50% <ø> (ø)
python 73.59% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/server/utils/transfer_filter.py 93.68% <ø> (ø)
app/server/api/credit_transfer_api.py 70.70% <66.66%> (-0.05%) ⬇️
app/server/utils/transfer_enums.py 100.00% <100.00%> (ø)
app/server/utils/mock_data.py 78.48% <0.00%> (-0.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tristanhcole tristanhcole left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tried to upgrade an existing database on the last migration I ran into this error. Migration from scratch worked.

psycopg2.errors.ActiveSqlTransaction: ALTER TYPE ... ADD cannot run inside a transaction block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants