Detect Mints - #857
Open
michielderoos wants to merge 2 commits into
Open
Detect Mints#857michielderoos wants to merge 2 commits into
michielderoos wants to merge 2 commits into
Conversation
michielderoos
marked this pull request as ready for review
September 15, 2022 17:36
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #857 +/- ##
=======================================
Coverage 47.79% 47.79%
=======================================
Files 374 374
Lines 19428 19432 +4
Branches 1793 1793
=======================================
+ Hits 9285 9287 +2
- Misses 10128 10130 +2
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tristanhcole
left a comment
Contributor
There was a problem hiding this comment.
When I tried to upgrade an existing database on the last migration I ran into this error. Migration from scratch worked.
psycopg2.errors.ActiveSqlTransaction: ALTER TYPE ... ADD cannot run inside a transaction block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the Pull Request
Adds mint type which we can filter by!
Note: One side effect is that this changes the metrics slightly (but I think in a desirable way) because it will keep massive spikes out of transfer metrics on mint days.
Note 2: This is not retroactive
Todo