Fix misleading “without pxpipe” cost comparison (#93)#124
Merged
Conversation
The dashboard labeled the average cost of small passthrough requests as what the larger imaged requests would have cost without pxpipe. Compare each paid imaged request with its own cache-aware text counterfactual instead, and explain the same-request calculation in the math drawer. Fixes #93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93
The dashboard compared two different kinds of requests.
The current $0.0722 means:
average cost of those 36 requests
Those 36 requests were passed through because they were too small to benefit from imaging. The dashboard incorrectly labels their average as “without pxpipe.”
It does not mean the 600 imaged requests would have cost $0.0722 without pxpipe.
Before
Displayed incorrectly as:
After
Displayed correctly as:
The bug is not that $0.0722 was calculated incorrectly. It was labeled and compared incorrectly.