fix(openai): correct rendered-context framing for annotation-only tool imaging#123
Merged
Merged
Conversation
teamchong
force-pushed
the
fix/gpt-rendered-context-wording
branch
from
July 18, 2026 22:55
0943b43 to
7e63201
Compare
teamchong
force-pushed
the
fix/gpt-rendered-context-wording
branch
from
July 19, 2026 02:56
7e63201 to
88e2884
Compare
…l imaging Align Chat and Responses framing with annotation-only tool imaging, preserving native tool definitions as authoritative. Includes output-level regressions adapted from #19.
teamchong
force-pushed
the
fix/gpt-rendered-context-wording
branch
from
July 19, 2026 02:58
88e2884 to
98a510d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages the still-valid part of #19 (by @rldyourmnd) and rebases it onto current
main.Why
mainalready fixed the double-billing that #19 originally targeted: commit4c78363reworked the GPT path to strip parameter annotations from the nativetools[]and image only those annotations (schemaAnnotationLines), keeping each tool's name and top-level description native. That superseded #19's functional change.What it left behind is stale framing text:
CHAT_HEADER/RESPONSES_HEADERand the two pointers still tell the model the images hold "full tool/schema documentation" and that the native JSON is merely supplemental — no longer true now that only parameter annotations are imaged.What
rendered-context wording) asserting the framing never claims "full tool" docs and always points at the native definitions.Credit
The rendered-context wording work is @rldyourmnd's from #19; the commit here is authored under their name. This PR only rebases it onto
main's annotation-only design and updates the wording to describe that design accurately.Supersedes #19 (whose functional change is already in
mainvia4c78363) — #19 can be closed.Full test suite green (783 tests) + typecheck clean.