Repository navigation
ci: report dbt schema and downstream risks on pull requests - #10
Open
PresentJay wants to merge 1 commit into
Open
PresentJay wants to merge 1 commit into
PresentJay wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on dbt-plan, a tool for reviewing column changes in compiled dbt models before a run. I've been trying it with existing projects, and the pitch facts and pitcher-season marts here seemed like a useful case for seeing which models a staging change could affect.
This workflow is limited to
warehouse/, using its local profile and sample-data setup; it leaves the separate MLB project out. Would you be open to reviewing whether the report is useful for this repository? Please feel free to close it if not.Prepared with AI assistance. The validation described below was run locally.
Technical notes and local checks
The warehouse project feeds pitch facts and pitcher-season marts. This adds an advisory PR schema comparison using its committed credential-free profile and sample-data setup, scoped to warehouse/; the separate MLB project remains outside this job.
The job uses
pull_request,contents: read, full Git history and local compilation. The wrapper is pinned to released commitd98f06e8674a1e68a009112b90d0d00c41416c33; the installed package is pinned separately to0.18.6.fail-on: neverkeeps completed findings advisory; compilation and execution errors still fail.Local verification at upstream
727b744f02dd2d01a2112ab3bfc032b2aedd6fe8(dbt-core 1.12.6 / dbt-duckdb 1.11.0):warehouse:dbt deps --profiles-dir . && dbt compile --profiles-dir . --no-partial-parse.6f0d8856e61f849b4a233e3ee8bbfa36585bb1f08f89b832cb812ca3ff4dc1b5); a fresh PyPI installation reporteddbt-plan 0.18.6with SQLGlot30.27.0, and the recorded reports were revalidated with that installation. The existing compile/control evidence is reused because the artifact, source, toolchain and input data are unchanged. A hosted execution of this new workflow has not yet been verified. The same-source report contained 0 changed models, verdictsafe, policy exit 0.pitcherfromwarehouse/models/staging/stg_trackman__pitches.sql, compiled the actual project, and randbt-plan check --format json: exit 1, 1 changed model marked destructive, 8 downstream risk entries. The report nameddim_game,dim_pitcher,fct_pitch.This is a static compiled-SQL review. Runtime query behavior, warehouse data and model-quality results remain with the existing build/tests. No credentials or publication permissions are added.
Disclosure: I maintain dbt-plan. This contribution was prepared with AI assistance; the local commands and results above were executed and recorded. Please feel free to decline if the extra advisory summary does not fit this project.