(data): Move thirdParty into variants for Base Set#1421
Conversation
…e cardmarket metadata
…dback Keep the reviewer-requested Base Set variant-level marketplace mapping changes while leaving workflow and tooling files out of the pure-data stack.
Move the generic Base Set marketplace ids onto the earliest supported print variant and drop placeholder-only OCR variants that require schema extensions. Keep the pure-data PR shape while preserving the clear jumbo listings with existing variant fields.
🃏 102 Cards ChangedDetails: 102 modified Alakazam (base1-1) (found using en)
File: [data/Base/Base Set/1.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/1.ts) Mewtwo (base1-10) (found using en)
File: [data/Base/Base Set/10.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/10.ts) Lightning Energy (base1-100) (found using en)
File: [data/Base/Base Set/100.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/100.ts) Psychic Energy (base1-101) (found using en)
File: [data/Base/Base Set/101.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/101.ts) Water Energy (base1-102) (found using en)
File: [data/Base/Base Set/102.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/102.ts) Nidoking (base1-11) (found using en)
File: [data/Base/Base Set/11.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/11.ts) Ninetales (base1-12) (found using en)
File: [data/Base/Base Set/12.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/12.ts) Poliwrath (base1-13) (found using en)
File: [data/Base/Base Set/13.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/13.ts) Raichu (base1-14) (found using en)
File: [data/Base/Base Set/14.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/14.ts) Venusaur (base1-15) (found using en)
File: [data/Base/Base Set/15.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/15.ts) Zapdos (base1-16) (found using en)
File: [data/Base/Base Set/16.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/16.ts) Beedrill (base1-17) (found using en)
File: [data/Base/Base Set/17.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/17.ts) Dragonair (base1-18) (found using en)
File: [data/Base/Base Set/18.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/18.ts) Dugtrio (base1-19) (found using en)
File: [data/Base/Base Set/19.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/19.ts) Blastoise (base1-2) (found using en)
File: [data/Base/Base Set/2.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/2.ts) Electabuzz (base1-20) (found using en)
File: [data/Base/Base Set/20.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/20.ts) Electrode (base1-21) (found using en)
File: [data/Base/Base Set/21.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/21.ts) Pidgeotto (base1-22) (found using en)
File: [data/Base/Base Set/22.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/22.ts) Arcanine (base1-23) (found using en)
File: [data/Base/Base Set/23.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/23.ts) Charmeleon (base1-24) (found using en)
File: [data/Base/Base Set/24.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/24.ts) Dewgong (base1-25) (found using en)
File: [data/Base/Base Set/25.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/25.ts) Dratini (base1-26) (found using en)
File: [data/Base/Base Set/26.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/26.ts) Farfetch'd (base1-27) (found using en)
File: [data/Base/Base Set/27.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/27.ts) Growlithe (base1-28) (found using en)
File: [data/Base/Base Set/28.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/28.ts) Haunter (base1-29) (found using en)
File: [data/Base/Base Set/29.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/29.ts) Chansey (base1-3) (found using en)
File: [data/Base/Base Set/3.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/3.ts) Ivysaur (base1-30) (found using en)
File: [data/Base/Base Set/30.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/30.ts) Jynx (base1-31) (found using en)
File: [data/Base/Base Set/31.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/31.ts) Kadabra (base1-32) (found using en)
File: [data/Base/Base Set/32.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/32.ts) Kakuna (base1-33) (found using en)
File: [data/Base/Base Set/33.ts](https://github.com/tcgdex/cards-database/blob/3abb3aa7cf2ec207ec490d8d0a1a8fc5946c2603/data/Base/Base Set/33.ts)
|
|
Hi, I will propose a new mapping of card variants and cardmarket’s versions There should be 2 shadowless variants for example(1st edition and Limited) |
im unable to check as cloudflare blocks me 🗡️ but we should have those already it might just be naming convention type: "holo", type: "holo", type: "holo", as far as im aware and i cant check your link but all the unlimiteds/limited where shadowed. so the 2 shadowless variants are covered by variant 2,3 |
thomas-bassett
left a comment
thomas-bassett
left a comment
There was a problem hiding this comment.
Make sure all have third-party ids, theres potentially a missprint variant in here that wont have that but nearly all should have them.
also your shuffling the ordering around without much reason to. if you want to change the order the shadowless-1stedition is the first card printed and is likely the most logical 1st variant
| @@ -86,20 +86,27 @@ const card: Card = { | |||
| variants: [ | |||
| { | |||
| type: "holo", | |||
There was a problem hiding this comment.
why are we messing with the order of variants? apart from moving the 1st edition print as disccused before there shouldnt be a need for any other change
| type: "holo", | ||
| subtype: "shadowless", | ||
| stamp: ["1st-edition"] | ||
| subtype: "unlimited" |
There was a problem hiding this comment.
still missing thirdparty ids. there might be some obvious ones that wont have ids but holo-unlimited definatly should have one
4 participants
Summary
thirdPartyids onto existingvariantsentries onlyTest plan
bun run validatecd server && bun run compilecd server && bun run --bun validatecd .bruno && bru run --env Developpement