feedback - #1
Open
ersel wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 - Your indentation is quite random. Install eslint so you've consistency across your codebase. Follow the readme here: https://github.com/MCRcodes/eslint-config
2 - You've magic numbers in your application code. Use module level constants to standardize and annotate these. See Russell's PR: https://github.com/ruzla/virtual-pet/blob/master/src/pet.js
3 - Don't commit skipped tests as part of your final work. Tests are only valuable if we actually run them.
4 - Good work on individual test setups. Elegant use of scope and beforeEach blocks 👍