refactor(fluid-type): container-based (cqi) instead of viewport (vw) - #280
Merged
Merged
Conversation
Fluid typography now scales relative to its container width instead of the viewport. This ensures correct sizing in multi-column layouts, sidebars, and cards — a heading in a narrow column gets appropriately smaller type regardless of the viewport size. Changes: - fluid-transform.js: vw → cqi, viewportMin/Max → containerMin/Max - tokens.config.json: containerMin=320, containerMax=1200 - Generated tokens: clamp(...cqi...) instead of clamp(...vw...) - Docs updated: explains container-type requirement and rationale Requires: container-type: inline-size on an ancestor element.
✅ Deploy Preview for ui-foundations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fluid typography now uses
cqi(container query inline) units instead ofvw.Why: viewport-based fluid type breaks in multi-column layouts — a heading in a narrow sidebar would be the same size as in the main content area. Container-based scaling fixes this.
Changes:
fluid-transform.js:vw→cqi, viewport bounds → container boundstokens.config.json: containerMin=320, containerMax=1200clamp(1.75rem, 1.48rem + 1.36cqi, 2.5rem)container-type: inline-sizerequirementRequires:
container-type: inline-sizeon a content ancestor.