Open
Conversation
Changed to allow other express based servers to import it and expose it on other urls
Before all the express configuration was being made here, and now you can run this as a server, or simply import this as a module, using the exported variable on the index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did several changes:
expressto a more recent version, and usingbody-parserinstead ofexpress.bodyParserindex.jsfile that contains the code that was before onserver.js, but instead of running the server in that file, exporting an express.Router variable to allow modularity with other services. This means that resize-server can now be used by other express based apps. (more on this later)server.jsto run the server as standalone if desired, withnpm startRegarding the modularity, the creation of the
index.jsfile means that on other server you could do: