feat(windows): migrate to NOTIFYICON_VERSION_4 - #331
Draft
Legend-Master wants to merge 12 commits into
Draft
Conversation
Legend-Master
force-pushed
the
notifyicon-version-4
branch
from
July 2, 2026 10:37
564f62b to
28852ab
Compare
Seems like `NIF_SHOWTIP` must be set on every `NIM_MODIFY` calls
Legend-Master
commented
Jul 6, 2026
| } | ||
| } | ||
| // Menu key | ||
| WM_CONTEXTMENU |
Contributor
Author
There was a problem hiding this comment.
This is unfortunately going to also fire on mouse clicks and there's no good way to check if it's fired from a mouse or keyboard... (meaning we will have duplicated events on mouse right clicks)
I'm thinking recording right mouse down and then skips this as a workaround, not sure how reliable is that though
…tifyicon-version-4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #324