Open
Conversation
5103957 to
1136627
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This PR does two things:
notafsdirectly from the unikernel'sconfig.mlso it doesn't need to be pinned manually (so that step is removed from the README)notafs_kv_rwfunction inconfig.mlthat takes a block implementation (and a few other parameters, see the doc) and returns akv_rwimplementation, so thatnotafs-kvcan be a real drop-in replacement for unikernels that already expect aKV(say, from a tar file)A few thoughts:
config.ml, but of course the goal would be to merge this code upstream inmirage. This can be a first draft towards that goalBlockand the library, as done initialy) if you prefernotafs_kv_roas well if needednotafs_kv_rwtakes aformatparameter to determine if the block should be formatted always, never or the first time. This could very well be a proper configure-time or run-time parameter as wellNotafs.KVtook the checksum implementation as its first argument instead of its second (we wouldn't need to define a type for checksums)