Repository navigation
Require necessity checks in agent plans and reviews - #953
Merged
Merged
Conversation
PR #953: Require necessity checks in agent plans and reviews2 files, +34 / -1 Scope✅ PR scope looks good. Structural✅ No structural bloat detected. Slop✅ Slop indicators look low. Static Analysis✅ Oxlint found no issues. CorrectnessNo extraneous code patterns detected. |
taras
marked this pull request as ready for review
October 19, 2026 08:20
taras
enabled auto-merge
October 19, 2026 08:20
4 of 7 tasks
Owner
Author
|
The security model and agreed The follow-up description records the implementation and cleanup work: implement the adapter with real consumers; assess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Planning and review can approve unnecessary machinery when they check only whether implementation follows an accepted plan. Tests created around that machinery can reinforce the assumption without establishing a production need.
What changes
Before: the role guides require reuse and concrete problems, but do not explicitly separate a mechanism's necessity from plan compliance during review.
After: the Planner justifies new registries, protocols, lifecycle guards and generic interfaces before freezing a plan. Planner and Architect reviews independently assess necessity and return unsupported assumptions for correction. The Planner also applies the existing comment rule to the final diff.
How to verify it
git diff --check HEAD^ HEADpasses.Scope confirmation