Skip to content

feat(workflow): add SDK parity dispatch workflow#1

Open
salihdev0 wants to merge 1 commit into
mainfrom
feat/sdk-parity
Open

feat(workflow): add SDK parity dispatch workflow#1
salihdev0 wants to merge 1 commit into
mainfrom
feat/sdk-parity

Conversation

@salihdev0

Copy link
Copy Markdown
  • Introduced a new GitHub Actions workflow for SDK parity dispatch.
  • Triggers on push and pull request events for specific paths.
  • Utilizes a reusable workflow from tapsilat/tapsilat-sdk-parity.

- Introduced a new GitHub Actions workflow for SDK parity dispatch.
- Triggers on push and pull request events for specific paths.
- Utilizes a reusable workflow from tapsilat/tapsilat-sdk-parity.
Copilot AI review requested due to automatic review settings April 8, 2026 20:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new GitHub Actions workflow to dispatch SDK parity checks via a reusable workflow in tapsilat/tapsilat-sdk-parity, scoped to changes in Zig build files and src/.

Changes:

  • Introduces sdk-parity-dispatch.yml workflow triggered on push, pull_request, and workflow_dispatch.
  • Limits automatic triggers to changes under src/**, build.zig, and build.zig.zon.
  • Calls a reusable workflow and inherits secrets from the caller.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +17 to +19
parity-dispatch:
uses: tapsilat/tapsilat-sdk-parity/.github/workflows/reusable-sdk-parity-dispatch.yml@main
secrets: inherit

Copilot AI Apr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reusable workflow is referenced with @main. This is mutable and can change behavior (and potentially expand the impact of secrets: inherit) without any change in this repo. Prefer pinning to an immutable ref (a version tag or commit SHA) so dispatch behavior is reproducible and supply-chain risk is reduced.

Copilot uses AI. Check for mistakes.
Comment on lines +4 to +8
push:
paths:
- "src/**"
- "build.zig"
- "build.zig.zon"

Copilot AI Apr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

push is configured without a branches filter, so this workflow will run on pushes to any branch (and path filters are not evaluated for tag pushes). If the intent is to only dispatch parity checks for the default branch (as in .github/workflows/test.yml), add an explicit branches: [main] (and/or tags-ignore) to avoid unexpected dispatches.

Copilot uses AI. Check for mistakes.
Comment on lines +16 to +19
jobs:
parity-dispatch:
uses: tapsilat/tapsilat-sdk-parity/.github/workflows/reusable-sdk-parity-dispatch.yml@main
secrets: inherit

Copilot AI Apr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this workflow calls into a reusable workflow and inherits secrets, consider explicitly setting least-privilege permissions: for the workflow/job (rather than relying on repo/org defaults). This helps prevent accidental privilege expansion if defaults change.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants