Repository navigation
docs: align implementation guides with registry and published results - #78
Merged
Merged
Conversation
Owner
Author
|
Final pre-merge self-review completed for head
Proceeding with the maintainer-authorized squash merge using the verified head as the expected SHA. Post-merge main CI and its automatic Pages deployment will be checked separately. No official benchmark or result publication has been dispatched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #71.
docs/IMPLEMENTATIONS.md.test_benchmark_*.pydiscovery pattern. Cohort members/order and active status derive from the registry; tests check important boundaries and canonical links/anchors without exact-paragraph snapshots or duplicated implementation counts.Scope
Baseline: freshly fetched main
eba127e65761ced4d0fef06a6c52cc2dc1fdb6ab. Issue #71, comments, open issues/PRs, successful main CI/Pages, AGENTS.md, registry, report metadata and related public guides were inspected before implementation. There was no competing open PR.Exactly five implementation guides and one test file change. The initial implementation was uploaded together in one commit; a second, formatting-only commit applies the exact pinned-Ruff patch reported by CI. Both are in this one branch/PR and will be squashed.
Root-tree comparison confirms that applications, dependencies, database, registry/measurement code, Compose, workflows, both READMEs, site and all
results/**remain identical to baseline. Historical four-stack/schema examples and v0.1.0 boundaries are preserved. Local plans/investigation notes are not committed.No official benchmark, manual performance experiment, new result publication, release, permission or protection change was requested or performed. Existing normal-CI smoke and Axum diagnostic are unchanged. #52 stays deferred; #59 is reserved for the next separately authorized official producer-to-Pages verification. No work on #72 or later issues is included.
TDD and local evidence
GitHub DNS and the full repository checkout were unavailable in the execution container, as were Docker, actionlint and Ruff. Local tests therefore used an isolated snapshot of fetched source bytes verified against GitHub blob SHAs, not a claimed full checkout or substituted implementation files.
python -O.git diff --checkpassed locally. Actual Python 3.10 execution is covered by CI, not claimed as local execution.CI and formatting correction
Initial run 36328802711 failed the pinned Ruff formatting gate. Python 3.10's 193 benchmark tests, 38 contract tests, actionlint and 21 workflow tests had passed, but later shared gates were skipped and that run was not accepted for merge.
Its formatting artifact
10934499130was downloaded and its SHA-256 verified against the job log. The patch only wraps one assertion call; Python ASTs before/after are identical. The corrected test blob is4ea6e1dc31c24f7d90f0d0500dbaf2d057afc387.Latest head:
5eb7084dd4fb01324c4f3312c188991a0edaa6ce.Normal CI: 36329214231, attempt 1. No manual rerun was requested. Its shared gates, all registered implementation jobs, contracts and Axum diagnostic have passed; smoke and the final
requiredaggregate must also succeed before merge. The final pre-merge audit will record completion against this exact head.Full local Make/native gates were unavailable. CI is the separate full-environment evidence for registry/Compose, benchmark tests (Python 3.10 and normal/optimized pinned Python), site, DB, Ruff, README generation, source checks, all implementation/contracts and non-publishing checks.
make test-workflowswas not invoked locally; normal CI runs its workflow-test and actionlint commands directly.Merge and post-merge boundary
The maintainer explicitly authorized Issue #71 implementation, this PR, squash merge and ordinary post-merge CI/Pages verification. Refresh main, PR head, checks, comments and reviews immediately before merging and pass the verified head SHA to the squash request. Verify automatic main CI and its existing Pages route afterward. Deployment/artifact verification must be distinguished from a direct check of publicly served bytes.